Bug 154079 - Fix assertions when loading from WebProcess
Summary: Fix assertions when loading from WebProcess
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-10 11:11 PST by Alex Christensen
Modified: 2016-02-10 12:56 PST (History)
0 users

See Also:

Attachments
Patch (8.28 KB, patch)
2016-02-10 11:21 PST, Alex Christensen 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-02-10 11:11:46 PST 
Fix assertions when loading from WebProcess
Comment 1 Alex Christensen 2016-02-10 11:21:34 PST 
Created attachment 271008 [details]
Patch
Comment 2 Alex Christensen 2016-02-10 12:40:55 PST 
Comment on attachment 271008 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271008&action=review

> Source/WebKit2/UIProcess/WebPageProxy.cpp:486
> +        m_process->processPool().sendToAllProcesses(Messages::WebProcess::EnsurePrivateBrowsingSession(m_sessionID));

My one concern with this approach is that it will use more memory in each WebProcess for the private browsing sessions they probably won't use, but I can't think of another good solution other than ensuring the private browsing session for each load in a private browsing session.
Comment 3 Alex Christensen 2016-02-10 12:56:21 PST 
http://trac.webkit.org/changeset/196384