Bug 154077 - Web Inspector: RemoteInspector's listings should include whether an AutomationTarget is paired
Summary: Web Inspector: RemoteInspector's listings should include whether an Automatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: 153934
  Show dependency tree / graph
 
Reported: 2016-02-10 09:54 PST by BJ Burg
Modified: 2016-02-11 16:02 PST (History)
12 users (show)

See Also:

Attachments
Proposed Fix (5.84 KB, patch)
2016-02-10 12:35 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
For Landing (5.82 KB, patch)
2016-02-11 15:14 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-02-10 09:54:47 PST 
Splitting from 153934.
Comment 1 Radar WebKit Bug Importer 2016-02-10 09:55:04 PST 
<rdar://problem/24589133>
Comment 2 BJ Burg 2016-02-10 12:35:58 PST 
Created attachment 271020 [details]
Proposed Fix
Comment 3 Joseph Pecoraro 2016-02-11 15:05:05 PST 
Comment on attachment 271020 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=271020&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:-529
> -    if (!target.automationAllowed())
> -        return nil;

So now, all AutomationTargets are always visible. Okay

> Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:85
> +#define WIRDrivableIsPairedKey                  @"WIRDrivableIsPairedKey"

This is the first time something like Drivable appears. Maybe something like WIRAutomationTargetIsPairedKey?
Comment 4 BJ Burg 2016-02-11 15:14:33 PST 
Created attachment 271097 [details]
For Landing
Comment 5 WebKit Commit Bot 2016-02-11 16:02:30 PST 
Comment on attachment 271097 [details]
For Landing

Clearing flags on attachment: 271097

Committed r196454: <http://trac.webkit.org/changeset/196454>
Comment 6 WebKit Commit Bot 2016-02-11 16:02:35 PST 
All reviewed patches have been landed.  Closing bug.