Bug 154076 – Add missing resource file for some imported/blink/compositing/squashing tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Danilo de Paula]

Tests were missing the blue.png file. With that, the expected are
pixel perfect.

[Danilo de Paula]

Created attachment 270995 [details]
patch v1

First time gardening, asking for review...

[WebKit Commit Bot]

Attachment 270995 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Danilo de Paula]

Created attachment 270998 [details]
patch v2

first time gardening, asking for review...

[Michael Catanzaro]

Comment on attachment 270998 [details]
patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=270998&action=review

Hi, thanks for your patch, it's much appreciated.

I am a bit confused, though, since you add a cross-platform file, but only modify the GTK expectations. Is it not a GTK-specific failure? Why does the test pass on other platforms without that file?

> LayoutTests/ChangeLog:3
> +        [GTK] Gardening for unexpected passes.

Since you're actually fixing a test, I wouldn't call this "gardening" which we generally use to refer to only updating test expectations or rebaselining tests. Instead, I'd say something like "[GTK] Fix layout test imported/blink/compositing/squashing/squashing-reflection-disallowed.html"

> LayoutTests/platform/gtk/TestExpectations:2399
> +webkit.org/b/151267 imported/blink/compositing/squashing/squashing-reflection-disallowed.html [ ImageOnlyFailure Pass ]

If the test is passing now, you should just remove it from the expectations file. [ ImageOnlyFailure Pass ] is used to indicate a broken test that sometimes passes and sometimes fails (flaky test).

[Michael Catanzaro]

Comment on attachment 270998 [details]
patch v2

(Removing from request queue until you get a chance to update your patch.)

[Lauro Moura]

Created attachment 403728 [details]
Patch

[Lauro Moura]

Waiting for EWS to come back to get some feedback from Mac/iOS before landing. Will keep an eye on post-commit bots for other ports/platforms.

[Lauro Moura]

Committed r264053: <https://trac.webkit.org/changeset/264053>