Bug 154075 - Optimize style invalidation after class attribute change
Summary: Optimize style invalidation after class attribute change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-10 09:27 PST by Antti Koivisto
Modified: 2016-02-10 12:49 PST (History)
7 users (show)

See Also:


Attachments
patch (33.42 KB, patch)
2016-02-10 10:16 PST, Antti Koivisto
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (905.77 KB, application/zip)
2016-02-10 11:07 PST, Build Bot
no flags Details
patch (33.63 KB, patch)
2016-02-10 11:12 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (33.80 KB, patch)
2016-02-10 11:31 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (33.72 KB, patch)
2016-02-10 11:34 PST, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-02-10 09:27:55 PST
Currently a class attribute change invalidates style for the entire element subtree for any class found in the active stylesheet set. We should determine exactly which descendants are affected and invalidate just those.
Comment 1 Antti Koivisto 2016-02-10 09:30:26 PST
rdar://problem/12526450
Comment 2 Antti Koivisto 2016-02-10 10:16:01 PST
Created attachment 271002 [details]
patch
Comment 3 Build Bot 2016-02-10 11:07:21 PST
Comment on attachment 271002 [details]
patch

Attachment 271002 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/810220

New failing tests:
svg/animations/classAttributeSettingCrash.html
fast/forms/number/number-size.html
Comment 4 Build Bot 2016-02-10 11:07:24 PST
Created attachment 271006 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Antti Koivisto 2016-02-10 11:12:51 PST
Created attachment 271007 [details]
patch
Comment 6 Antti Koivisto 2016-02-10 11:31:52 PST
Created attachment 271012 [details]
patch
Comment 7 Antti Koivisto 2016-02-10 11:34:36 PST
Created attachment 271014 [details]
patch
Comment 8 Andreas Kling 2016-02-10 11:57:07 PST
Comment on attachment 271014 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=271014&action=review

r=me, very cool :)

> Source/WebCore/ChangeLog:45
> +            Make this is a member.

Make this is a typo.
Comment 9 Antti Koivisto 2016-02-10 12:49:02 PST
https://trac.webkit.org/r196383