WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
154058
Add internal benchmark tests for CSS mix-blend-modes and filters
https://bugs.webkit.org/show_bug.cgi?id=154058
Summary
Add internal benchmark tests for CSS mix-blend-modes and filters
Said Abou-Hallawa
Reported
2016-02-09 17:52:26 PST
These tests will be based on the bouncing particles css tests but slightly modified to apply the css mix-blend-modes and filters.
Attachments
Patch
(6.52 KB, patch)
2016-02-09 18:01 PST
,
Said Abou-Hallawa
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1
2016-02-09 18:01:23 PST
Created
attachment 270966
[details]
Patch
Jon Lee
Comment 2
2016-02-09 23:36:45 PST
Comment on
attachment 270966
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=270966&action=review
Unofficial r=me
> PerformanceTests/Animometer/resources/extensions.js:87 > + browserPrefix: function ()
No space between function and (). This result is derived and never cached; seems better to rename this to getBrowserPrefix()?
> PerformanceTests/Animometer/resources/extensions.js:93 > + .match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o'])
This is hard to read. Can we unfold this using if clauses instead?
Said Abou-Hallawa
Comment 3
2016-02-10 12:45:49 PST
Committed
r196381
: <
http://trac.webkit.org/changeset/196381
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug