Bug 154058 - Add internal benchmark tests for CSS mix-blend-modes and filters
Summary: Add internal benchmark tests for CSS mix-blend-modes and filters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-09 17:52 PST by Said Abou-Hallawa
Modified: 2016-02-10 17:08 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.52 KB, patch)
2016-02-09 18:01 PST, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2016-02-09 17:52:26 PST
These tests will be based on the bouncing particles css tests but slightly modified to apply the css mix-blend-modes and filters.
Comment 1 Said Abou-Hallawa 2016-02-09 18:01:23 PST
Created attachment 270966 [details]
Patch
Comment 2 Jon Lee 2016-02-09 23:36:45 PST
Comment on attachment 270966 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270966&action=review

Unofficial r=me

> PerformanceTests/Animometer/resources/extensions.js:87
> +    browserPrefix: function ()

No space between function and (). This result is derived and never cached; seems better to rename this to getBrowserPrefix()?

> PerformanceTests/Animometer/resources/extensions.js:93
> +            .match(/-(moz|webkit|ms)-/) || (styles.OLink === '' && ['', 'o'])

This is hard to read. Can we unfold this using if clauses instead?
Comment 3 Said Abou-Hallawa 2016-02-10 12:45:49 PST
Committed r196381: <http://trac.webkit.org/changeset/196381>