Bug 154054 - Modern IDB: TransactionOperation objects leak
Summary: Modern IDB: TransactionOperation objects leak
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 154015
  Show dependency tree / graph
 
Reported: 2016-02-09 16:09 PST by Brady Eidson
Modified: 2016-02-23 09:53 PST (History)
5 users (show)

See Also:

Attachments
Patch v1 (5.68 KB, patch)
2016-02-09 16:17 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-02-09 16:09:57 PST 
Modern IDB: TransactionOperation objects leak
Comment 1 Brady Eidson 2016-02-09 16:17:16 PST 
Created attachment 270961 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-02-09 16:18:22 PST 
Attachment 270961 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:104:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:124:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2016-02-09 17:15:11 PST 
Comment on attachment 270961 [details]
Patch v1

Clearing flags on attachment: 270961

Committed r196349: <http://trac.webkit.org/changeset/196349>
Comment 4 WebKit Commit Bot 2016-02-09 17:15:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2016-02-23 09:52:45 PST 
This change has cut the total amount of leaks on the leaks bot roughly in half. Nice!
Comment 6 Brady Eidson 2016-02-23 09:53:43 PST 
(In reply to comment #5)
> This change has cut the total amount of leaks on the leaks bot roughly in
> half. Nice!

👍👏