Bug 154047 - Don't crash if we fail to parse a builtin
Summary: Don't crash if we fail to parse a builtin
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2016-02-09 14:22 PST by Filip Pizlo
Modified: 2016-02-09 14:42 PST (History)
5 users (show)

See Also:

the patch (1.48 KB, patch)
2016-02-09 14:24 PST, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-09 14:22:13 PST
Crashing probably seemed like a good idea at the time, but we could get here in case of a near stack overflow, so that the parser bails because of recursion.
Comment 1 Filip Pizlo 2016-02-09 14:24:01 PST
Created attachment 270953 [details]
the patch
Comment 2 Mark Lam 2016-02-09 14:26:37 PST
Comment on attachment 270953 [details]
the patch

Comment 3 Filip Pizlo 2016-02-09 14:42:21 PST
Landed in http://trac.webkit.org/changeset/196337