* SUMMARY Limit max and min zoom factor of Inspector. Currently there is no limit to zoom in and out, which can provide a poor experience.
<rdar://problem/24571326>
Created attachment 270940 [details] [PATCH] Proposed Fix
Comment on attachment 270940 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=270940&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + Please state what the intended limits are, so I can double-check you did it right ;-) > Source/WebInspectorUI/ChangeLog:24 > + Remove prevent default which would happen implicitly for these. This comment confused me. Maybe say 'remove redundant preventDefault calls' > Source/WebInspectorUI/UserInterface/Base/Main.js:1946 > + const maximumZoom = 2.4; If we want 6 zoom levels, this should be 2.2. Right? 1 + (.2 * 6) = 2.2 > Source/WebInspectorUI/UserInterface/Base/Main.js:1959 > + const minimumZoom = 0.6; For 3 zoom levels, it should be 0.4.
> > Source/WebInspectorUI/ChangeLog:8 > > + > > Please state what the intended limits are, so I can double-check you did it > right ;-) The intended limits are what look good to my eye and roughly matched Safari. I added a comment to the ChangeLog. > > > Source/WebInspectorUI/UserInterface/Base/Main.js:1946 > > + const maximumZoom = 2.4; > > If we want 6 zoom levels, this should be 2.2. Right? 1 + (.2 * 6) = 2.2 I think its more important to have a good zoom then have 6 levels. Safari went up to 3, so I felt 2.4 was better than 2.2 in terms of comparing the two. > > Source/WebInspectorUI/UserInterface/Base/Main.js:1959 > > + const minimumZoom = 0.6; > > For 3 zoom levels, it should be 0.4. I think 0.6 was already looking super small. Our UI starts to break at the seems at this zoom level. Going smaller didn't seem useful.
Created attachment 270943 [details] [PATCH] For Landing
Created attachment 270944 [details] [PATCH] For Landing
Comment on attachment 270944 [details] [PATCH] For Landing Clearing flags on attachment: 270944 Committed r196325: <http://trac.webkit.org/changeset/196325>