Bug 154040 – CSP: Extract helper classes into their own files

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Daniel Bates]

Currently ContentSecurityPolicy.cpp contains class definitions for various helper classes. We should extract these helper classes into their own files to better organize and compartmentalize the Content Security Policy code.

[Radar WebKit Bug Importer]

<rdar://problem/24571189>

[Daniel Bates]

Created attachment 270941 [details]
Patch

[Brent Fulgham]

Comment on attachment 270941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270941&action=review

r=me. Please clean up the ChangeLog a bit so it's not so large -- most of that auto-generated information is not useful.

> Source/WebCore/ChangeLog:16
> +        (WebCore::ContentSecurityPolicy::didReceiveHeader): Ditto.

You should shrink this ChangeLog by just indicating:

WebCore::ContentSecurityPolicy implementation moved to page/csp/ContentSecurityPolicy.{h, cpp}:
WebCore::CSPSource implementation moved to page/csp/ContentSecurityPolicySource.{h, cpp}
... etc ...

> Source/WebCore/ChangeLog:35
> +        (WebCore::isSourceListNone): Deleted.

.... and mention which files these bare functions moved to.

[Daniel Bates]

(In reply to comment #3)
> [...]
> > Source/WebCore/ChangeLog:16
> > +        (WebCore::ContentSecurityPolicy::didReceiveHeader): Ditto.
> 
> You should shrink this ChangeLog by just indicating:
> 
> WebCore::ContentSecurityPolicy implementation moved to
> page/csp/ContentSecurityPolicy.{h, cpp}:
> WebCore::CSPSource implementation moved to
> page/csp/ContentSecurityPolicySource.{h, cpp}
> ... etc ...
> 

Will fix before landing.

> > Source/WebCore/ChangeLog:35
> > +        (WebCore::isSourceListNone): Deleted.
> 
> .... and mention which files these bare functions moved to.

Will fix before landing.

[Daniel Bates]

Committed r196350: <http://trac.webkit.org/changeset/196350>