Bug 154032 - Modern IDB: IDBOpenDBRequests leak
Summary: Modern IDB: IDBOpenDBRequests leak
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
Depends on:
Blocks: 149117 154015
  Show dependency treegraph
Reported: 2016-02-09 08:57 PST by Brady Eidson
Modified: 2016-02-09 09:40 PST (History)
2 users (show)

See Also:

Patch v1 (13.99 KB, patch)
2016-02-09 09:21 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-02-09 08:57:35 PST
Modern IDB: IDBOpenDBRequests leak

There's a ref cycle between IDBTransaction and IDBOpenDBRequest.

Breaking IDBTransaction's ref to the request is easy - *IF* the request is able to potentially manage the end of its own lifetime, which is tied to its final event dispatch.

Doing that requires a new Event class that holds the final ref to the request.
Comment 1 Brady Eidson 2016-02-09 09:21:59 PST
Created attachment 270934 [details]
Patch v1
Comment 2 WebKit Commit Bot 2016-02-09 09:40:45 PST
Comment on attachment 270934 [details]
Patch v1

Clearing flags on attachment: 270934

Committed r196313: <http://trac.webkit.org/changeset/196313>
Comment 3 WebKit Commit Bot 2016-02-09 09:40:48 PST
All reviewed patches have been landed.  Closing bug.