Bug 154021 - Error construction for inlined operations should not use the inliner's CodeBlock
Summary: Error construction for inlined operations should not use the inliner's CodeBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-08 17:32 PST by Keith Miller
Modified: 2016-02-08 19:46 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.45 KB, patch)
2016-02-08 17:45 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (3.50 KB, patch)
2016-02-08 18:27 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (3.51 KB, patch)
2016-02-08 18:32 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-02-08 17:32:49 PST 
Error construction for inlined operations should not use the inliner's CodeBlock
Comment 1 Keith Miller 2016-02-08 17:45:16 PST 
Created attachment 270900 [details]
Patch
Comment 2 Mark Lam 2016-02-08 18:04:36 PST 
Comment on attachment 270900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270900&action=review

r=me.

Can you fix the styling in the test to be more webkit style compliant?

> Source/JavaScriptCore/ChangeLog:12
> +        oprationIn as we expected to be able to find the text "in" in the source.

typo operationIn.
Comment 3 Keith Miller 2016-02-08 18:13:59 PST 
rdar://problem/22725607
Comment 4 Keith Miller 2016-02-08 18:14:44 PST 
Comment on attachment 270900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270900&action=review

>> Source/JavaScriptCore/ChangeLog:12
>> +        oprationIn as we expected to be able to find the text "in" in the source.
> 
> typo operationIn.

Fixed.
Comment 5 Keith Miller 2016-02-08 18:27:33 PST 
Created attachment 270904 [details]
Patch for landing
Comment 6 Keith Miller 2016-02-08 18:28:15 PST 
> Can you fix the styling in the test to be more webkit style compliant?

Missed this before. Fixed also.
Comment 7 Mark Lam 2016-02-08 18:30:55 PST 
Comment on attachment 270904 [details]
Patch for landing

I think you introduced an error in the test after the style fix. Please fix before landing.
Comment 8 Keith Miller 2016-02-08 18:32:37 PST 
Created attachment 270905 [details]
Patch for landing
Comment 9 Keith Miller 2016-02-08 18:35:37 PST 
> I think you introduced an error in the test after the style fix. Please fix
> before landing.

Whoops. Good catch. I had a copy my project root directory and didn't cp the last set of fixes. Should be good to go now.
Comment 10 WebKit Commit Bot 2016-02-08 19:46:40 PST 
Comment on attachment 270905 [details]
Patch for landing

Clearing flags on attachment: 270905

Committed r196302: <http://trac.webkit.org/changeset/196302>
Comment 11 WebKit Commit Bot 2016-02-08 19:46:43 PST 
All reviewed patches have been landed.  Closing bug.