Bug 154016 - Web Inspector: Search doesn't seem to find text that is present in multiple places
Summary: Web Inspector: Search doesn't seem to find text that is present in multiple p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-08 16:09 PST by Joseph Pecoraro
Modified: 2016-02-08 17:55 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.61 KB, patch)
2016-02-08 16:11 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-02-08 16:09:27 PST 
* SUMMARY
Search doesn't seem to find text that is present in multiple places.

* STEPS TO REPRODUCE
1. Inspect https://www.icloud.com/#photos
2. Global search for “SFNSText”
  => doesn't seem to find results in packed.css
  => inspector seems broken (try 1+1 in console)

* NOTES
It looks like the inspector is sending search requests for the thousands of anonymous, unnamed script evaluations. While potentially useful, I don't think we should be including unnamed scripts when considering search. We should prioritize resources, named scripts, and the DOM.
Comment 1 Joseph Pecoraro 2016-02-08 16:09:34 PST 
<rdar://problem/23391307>
Comment 2 Joseph Pecoraro 2016-02-08 16:11:05 PST 
Created attachment 270891 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-02-08 17:06:38 PST 
Comment on attachment 270891 [details]
[PATCH] Proposed Fix

r=me
Comment 4 WebKit Commit Bot 2016-02-08 17:55:50 PST 
Comment on attachment 270891 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 270891

Committed r196285: <http://trac.webkit.org/changeset/196285>
Comment 5 WebKit Commit Bot 2016-02-08 17:55:54 PST 
All reviewed patches have been landed.  Closing bug.