Bug 154004 - Web Inspector: Uncaught exception merging script profiler records
Summary: Web Inspector: Uncaught exception merging script profiler records
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-08 13:41 PST by Joseph Pecoraro
Modified: 2016-02-08 19:33 PST (History)
8 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.68 KB, patch)
2016-02-08 13:42 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-02-08 13:41:13 PST 
* SUMMARY
Uncaught exception merging script profiler records.

[Error] Uncaught exception in inspector page while handling event ScriptProfiler.trackingComplete
TypeError: null is not an object (evaluating 'record2.startTime')
Comment 1 Radar WebKit Bug Importer 2016-02-08 13:41:42 PST 
<rdar://problem/24554961>
Comment 2 Joseph Pecoraro 2016-02-08 13:42:12 PST 
Created attachment 270879 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-02-08 13:46:53 PST 
Comment on attachment 270879 [details]
[PATCH] Proposed Fix

r=me

is there a way to test this regression?
Comment 4 Joseph Pecoraro 2016-02-08 19:05:46 PST 
> is there a way to test this regression?

There is a lot in TimelineManager that we probably should be testing. But I'd rather leave it until we rewrite some more of this code later. The Web wrapping events stuff is unfortunate. As we get closer to a ProfileView and TimelinesUI stuff, we might even be able to drop some of this code.
Comment 5 WebKit Commit Bot 2016-02-08 19:33:20 PST 
Comment on attachment 270879 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 270879

Committed r196301: <http://trac.webkit.org/changeset/196301>
Comment 6 WebKit Commit Bot 2016-02-08 19:33:24 PST 
All reviewed patches have been landed.  Closing bug.