Bug 154000 – Web Inspector: eliminate the linear and rendering frames TimelineOverview subclasses

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Eliminate the linear and rendering frames TimelineOverview subclasses. TimelineRecordingContentView maintains two separate overviews, and switches between them depending on the view mode (Timelines vs Rendering Frames). This seems overly complicated, since the two subclasses only differ in the settings they provide (selection, zoom level, ruler snapping, etc). TimelineOverview should encapsulate the ViewMode, rather than the sidebar, and maintain settings for each mode.

This change is motivated in part by https://bugs.webkit.org/show_bug.cgi?id=153034. Moving the timelines tree outline into the overview is made more awkward by the existence of two separate overview classes.

[Radar WebKit Bug Importer]

<rdar://problem/24553105>

[Matt Baker]

Created attachment 271369 [details]
[Patch] Proposed Fix

[Timothy Hatcher]

Comment on attachment 271369 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=271369&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:34
> +        this._timelinesSettings = this._createViewModeSettings(WebInspector.TimelineOverview.ViewMode.Timelines, 0.0001, 60, 0.01, 0, 15);

_timelinesViewModeSettings would read better than two plural nouns.

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:39
> +            this._renderingFramesSettings = this._createViewModeSettings(WebInspector.TimelineOverview.ViewMode.RenderingFrames, minimumDurationPerPixel, maximumDurationPerPixel, minimumDurationPerPixel, 0, 100);

_renderingFramesViewModeSettings

> Source/WebInspectorUI/UserInterface/Views/TimelineOverview.js:653
> +        else
> +            timelineViewMode = WebInspector.TimelineOverview.ViewMode.Timelines;

Could make this the default assignment for the let, and just keep the if without an else.

[Matt Baker]

Created attachment 271377 [details]
[Patch] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 271377 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 271377

Committed r196606: <http://trac.webkit.org/changeset/196606>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.