Bug 153993 – [GTK] Allow to run the WebKitGTK+ MiniBrowser with the run-benchmark script.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

As stated on https://lists.webkit.org/pipermail/webkit-dev/2016-February/027948.html we would like to implement support on the run-benchmark script to execute the tests also with the WebKitGTK+ MiniBrowser.

[Carlos Alberto Lopez Perez]

Created attachment 272015 [details]
Patch

[WebKit Commit Bot]

Attachment 272015 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:89:  [SimpleHTTPServerDriver.kill_server] Instance of 'Popen' has no 'terminate' member  [pylint/E1101] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Comment on attachment 272015 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272015&action=review

Thanks for the patch!

> Tools/MiniBrowser/gtk/main.c:43
> +static char *geometry = NULL;

This doesn't need to be initialized, since all those statics are already 0 initialized.

> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:45
> +        args.append("%s" % url)

I guess this could just be args.append(url)

> Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:88
> +            if self._server_process.poll() == None:

is None

> Tools/Scripts/webkitpy/benchmark_runner/utils.py:28
> +    filelist = os.listdir(dirname)
> +    filelist.remove(base_class_file)
> +    filelist.insert(0, base_class_file)
> +    for filename in filelist:
>          if not filename.endswith('.py') or filename in ['__init__.py']:
>              continue
>          module_name = filename[:-3]

I think this could be simplified as something like this:

filelist = [base_class_file] + [f for f in os.listdir(dirname) if f.endswith('.py') and f not in ['__init__.py', base_class_file]]
for filename in filelist:
    module_name = os.path.splitext(filename)[0]

[Carlos Alberto Lopez Perez]

Committed r196979: <http://trac.webkit.org/changeset/196979>

[Carlos Alberto Lopez Perez]

Comment on attachment 272015 [details]
Patch

Clearing flags

[Michael Catanzaro]

Committed r197241: <http://trac.webkit.org/changeset/197241>