WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
153985
Remove __weak from WKAirPlayRoutePicker.mm to fix build warning.
https://bugs.webkit.org/show_bug.cgi?id=153985
Summary
Remove __weak from WKAirPlayRoutePicker.mm to fix build warning.
Jeremy Jones
Reported
2016-02-08 07:39:18 PST
Remove __weak from WKAirPlayRoutePicker.mm to fix build warning.
Attachments
Patch
(1.55 KB, patch)
2016-02-08 07:42 PST
,
Jeremy Jones
darin
: review+
Details
Formatted Diff
Diff
Patch for landing.
(1.51 KB, patch)
2016-02-08 10:28 PST
,
Jeremy Jones
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Jones
Comment 1
2016-02-08 07:40:30 PST
rdar://problem/24485348
Jeremy Jones
Comment 2
2016-02-08 07:42:55 PST
Created
attachment 270854
[details]
Patch
Darin Adler
Comment 3
2016-02-08 08:54:19 PST
Comment on
attachment 270854
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=270854&action=review
> Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:53 > - __weak WKContentView* _view; // Weak reference. > + __unsafe_unretained WKContentView* _view; // Weak reference.
Since this code is not ARC, we should not have any modifier at all. Is there any value to stating __unsafe_unretained here?
Darin Adler
Comment 4
2016-02-08 08:54:43 PST
Comment on
attachment 270854
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=270854&action=review
>> Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:53 >> + __unsafe_unretained WKContentView* _view; // Weak reference. > > Since this code is not ARC, we should not have any modifier at all. Is there any value to stating __unsafe_unretained here?
I suggest removing __weak and not replacing it with anything.
Jeremy Jones
Comment 5
2016-02-08 10:25:21 PST
(In reply to
comment #4
)
> Comment on
attachment 270854
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=270854&action=review
> > >> Source/WebKit2/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:53 > >> + __unsafe_unretained WKContentView* _view; // Weak reference. > > > > Since this code is not ARC, we should not have any modifier at all. Is there any value to stating __unsafe_unretained here? > > I suggest removing __weak and not replacing it with anything.
If this were a header that might get included in an ARC code, it would be necessary. Since it is in an .mm file, the only value is in annotating the fact that this is an unretained reference. I'll remove it.
Jeremy Jones
Comment 6
2016-02-08 10:28:41 PST
Created
attachment 270863
[details]
Patch for landing.
WebKit Commit Bot
Comment 7
2016-02-08 11:27:03 PST
Comment on
attachment 270863
[details]
Patch for landing. Clearing flags on attachment: 270863 Committed
r196260
: <
http://trac.webkit.org/changeset/196260
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug