Bug 153972 - Make sure that locking code that relies on module boundaries for compiler fences uses NEVER_INLINE
Summary: Make sure that locking code that relies on module boundaries for compiler fen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-07 21:28 PST by Filip Pizlo
Modified: 2016-02-08 10:58 PST (History)
4 users (show)

See Also:


Attachments
the patch (4.12 KB, patch)
2016-02-07 21:59 PST, Filip Pizlo
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-07 21:28:37 PST
...
Comment 1 Filip Pizlo 2016-02-07 21:29:14 PST
One example is the locking code.  I don't know what would happen if the locking slow paths were inlined, and the compiler could "see" the locking code at a lock acquisition site.
Comment 2 Filip Pizlo 2016-02-07 21:59:36 PST
Created attachment 270842 [details]
the patch
Comment 3 Filip Pizlo 2016-02-08 10:58:27 PST
Landed in http://trac.webkit.org/changeset/196259