Bug 153968 – Attribute getters should not require an explicit 'this' value for Window properties

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Attribute getters should not require an explicit 'this' value for Window properties. This is because the Window interface is marked as [ImplicitThis]:
- http://heycam.github.io/webidl/#ImplicitThis
- https://www.w3.org/Bugs/Public/show_bug.cgi?id=29421

This matches the behavior of Firefox and the expectations of the W3C web-platform-tests.

[Chris Dumez]

Created attachment 270833 [details]
WIP Patch

[Chris Dumez]

Created attachment 270836 [details]
Patch

[Chris Dumez]

Created attachment 270864 [details]
Patch

[Gavin Barraclough]

Comment on attachment 270864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270864&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2296
>                  }

OOI could do away with the if/else in the perl & the ?: in the C++ by doing something like this:

push(@implContent, "    if (decodedThisValue.isUndefinedOrNull()) decodedThisValue = state->thisValue().toThis(state, NotStrictMode);\n") if ($interface->extendedAttributes->{"ImplicitThis"});
push(@implContent, "    auto* castedThis = $castingFunction(decodedThisValue);\n");

Not sure if that's really much better tho.

[Chris Dumez]

Comment on attachment 270864 [details]
Patch

Clearing flags on attachment: 270864

Committed r196303: <http://trac.webkit.org/changeset/196303>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.