Will probably need to update the JS string extraction script.
<rdar://problem/24542505>
Created attachment 357764 [details] Patch
Comment on attachment 357764 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357764&action=review It would be nice if you could add a single usage of each form that we expect to work into the codebase, so that the script can be shown to work correctly. > Tools/Scripts/extract-localizable-js-strings:-78 > - print "$file:$.:WARNING: $&\n" while s/WI\.UIString\(.*?\)//; Why did this warning get removed? It seems useful in the case where the arguments to UIString could not be parsed. > Tools/Scripts/extract-localizable-js-strings:154 > + $localizedStrings .= " // $commentByKey{$key}" if length $commentByKey{$key}; To make this consistent with Cocoa lproj files, please make the following changes: - the comment should precede the localized string - use /* multiline comment style */
Created attachment 357786 [details] Patch
Comment on attachment 357786 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=357786&action=review r=me > Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js:68 > + const format = WI.UIString("%s%%", "audit-percentage-pass", "The number of tests that passed expressed as a percentage, followed by a literal %."); Let's follow existing practice in Safari and use human-readable keys. In this case, something like "Percentage (of audits)". Ideally we wouldn't have a percent UIString floating by itself since it may interact with surrounding text, but I don't think it's a real problem in this specific instance.
Created attachment 357825 [details] Patch
Comment on attachment 357825 [details] Patch Clearing flags on attachment: 357825 Committed r239452: <https://trac.webkit.org/changeset/239452>
All reviewed patches have been landed. Closing bug.