Bug 153961 - [cmake] Move LLVM detection for LLVMDisassembler to OptionsCommon.cmake
Summary: [cmake] Move LLVM detection for LLVMDisassembler to OptionsCommon.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-07 08:20 PST by Konstantin Tokarev
Modified: 2016-02-07 11:25 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2016-02-07 08:24 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Patch (2.73 KB, patch)
2016-02-07 09:49 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-02-07 08:20:56 PST 
In r196077 ENABLE_FTL_JIT was replaced with USE_LLVM_DISASSEMBLER, however x86_64 requirement is appropriate only for FTL.
Comment 1 Konstantin Tokarev 2016-02-07 08:24:09 PST 
Created attachment 270818 [details]
Patch
Comment 2 Konstantin Tokarev 2016-02-07 08:25:45 PST 
BTW, it may be better to move this check to OptionsCommon, however it would require consensus on required LLVM version.
Comment 3 Michael Catanzaro 2016-02-07 09:07:49 PST 
Comment on attachment 270818 [details]
Patch

I agree, it'd be better to move this from the platform-specific options files to OptionsCommon.

We don't care about the required LLVM version since we don't expose USE_LLVM_DISASSEMBLER. I suspect LLVM 3.7 was only required for FTL.
Comment 4 Konstantin Tokarev 2016-02-07 09:49:58 PST 
Created attachment 270820 [details]
Patch
Comment 5 Konstantin Tokarev 2016-02-07 10:18:10 PST 
(In reply to comment #3)
> Comment on attachment 270818 [details]
> Patch
> 
> I agree, it'd be better to move this from the platform-specific options
> files to OptionsCommon.

Done.
Comment 6 Michael Catanzaro 2016-02-07 10:39:30 PST 
Comment on attachment 270820 [details]
Patch

Great, thanks.
Comment 7 WebKit Commit Bot 2016-02-07 11:25:34 PST 
Comment on attachment 270820 [details]
Patch

Clearing flags on attachment: 270820

Committed r196241: <http://trac.webkit.org/changeset/196241>
Comment 8 WebKit Commit Bot 2016-02-07 11:25:39 PST 
All reviewed patches have been landed.  Closing bug.