RESOLVED WONTFIX 153958
Refactor NetscapePluginX11 constructors 
https://bugs.webkit.org/show_bug.cgi?id=153958
Summary Refactor NetscapePluginX11 constructors
Michael Catanzaro
Reported 2016-02-06 20:29:51 PST
We should fix this warning: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h:67:14: warning: private field 'm_windowID' is not used [-Wunused-private-field] uint64_t m_windowID { 0 }; ^ It's not trivial though, because we have an extra constructor to assign this via a parameter, so we should remove that parameter. But then we wind up with two different constructors with the same parameter list. Someone familiar with the code should take a look. I also do not like that we have a static create function but also public constructors. The class is not refcounted, so I don't see value in the create function.
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2022-07-01 09:58:56 PDT
Based on this commit - NPAPI support on X11 was also removed: https://github.com/WebKit/WebKit/commit/a2cbf796cd72940dc075a76a414e75d51e9859b4 Can this be marked as "RESOLVED WONTFIX". Thanks!
Note You need to log in before you can comment on or make changes to this bug.