Bug 153955 - FTL must store the call site index before runtime calls, even if it's the tail call slow path
Summary: FTL must store the call site index before runtime calls, even if it's the tai...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-06 15:08 PST by Filip Pizlo
Modified: 2016-02-06 17:51 PST (History)
5 users (show)

See Also:


Attachments
the patch (2.24 KB, patch)
2016-02-06 15:14 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-02-06 15:08:14 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-02-06 15:14:00 PST
Created attachment 270807 [details]
the patch
Comment 2 Saam Barati 2016-02-06 15:23:07 PST
Comment on attachment 270807 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216
> +                // with the call site index of our frame. Bad things happen if it's not set.

Might be worth adding a test for this if it's not too difficult to write one.
Comment 3 Saam Barati 2016-02-06 15:24:04 PST
Comment on attachment 270807 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review

> Source/JavaScriptCore/ChangeLog:9
> +        The reasoning is explained in a comment in compileTailCall().

It's probably worth writing out the comment in the change log for posterity.
Comment 4 Filip Pizlo 2016-02-06 17:40:42 PST
(In reply to comment #2)
> Comment on attachment 270807 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270807&action=review
> 
> > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216
> > +                // with the call site index of our frame. Bad things happen if it's not set.
> 
> Might be worth adding a test for this if it's not too difficult to write one.

I'll try. :-)
Comment 5 Filip Pizlo 2016-02-06 17:40:49 PST
(In reply to comment #3)
> Comment on attachment 270807 [details]
> the patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270807&action=review
> 
> > Source/JavaScriptCore/ChangeLog:9
> > +        The reasoning is explained in a comment in compileTailCall().
> 
> It's probably worth writing out the comment in the change log for posterity.

Will do.
Comment 6 Filip Pizlo 2016-02-06 17:51:26 PST
Landed in http://trac.webkit.org/changeset/196232