RESOLVED FIXED 153955
FTL must store the call site index before runtime calls, even if it's the tail call slow path 
https://bugs.webkit.org/show_bug.cgi?id=153955
Summary FTL must store the call site index before runtime calls, even if it's the tai...
Filip Pizlo
Reported 2016-02-06 15:08:14 PST
Patch forthcoming.
Attachments
the patch (2.24 KB, patch)
2016-02-06 15:14 PST, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-02-06 15:14:00 PST
Created attachment 270807 [details] the patch
Saam Barati
Comment 2 2016-02-06 15:23:07 PST
Comment on attachment 270807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216 > + // with the call site index of our frame. Bad things happen if it's not set. Might be worth adding a test for this if it's not too difficult to write one.
Saam Barati
Comment 3 2016-02-06 15:24:04 PST
Comment on attachment 270807 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=270807&action=review > Source/JavaScriptCore/ChangeLog:9 > + The reasoning is explained in a comment in compileTailCall(). It's probably worth writing out the comment in the change log for posterity.
Filip Pizlo
Comment 4 2016-02-06 17:40:42 PST
(In reply to comment #2) > Comment on attachment 270807 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270807&action=review > > > Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:5216 > > + // with the call site index of our frame. Bad things happen if it's not set. > > Might be worth adding a test for this if it's not too difficult to write one. I'll try. :-)
Filip Pizlo
Comment 5 2016-02-06 17:40:49 PST
(In reply to comment #3) > Comment on attachment 270807 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270807&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + The reasoning is explained in a comment in compileTailCall(). > > It's probably worth writing out the comment in the change log for posterity. Will do.
Filip Pizlo
Comment 6 2016-02-06 17:51:26 PST
Landed in http://trac.webkit.org/changeset/196232
Note You need to log in before you can comment on or make changes to this bug.