Bug 153904 - Web Inspector: Update MemoryTimelineView for new ruler height
Summary: Web Inspector: Update MemoryTimelineView for new ruler height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on: 153034
Blocks:
  Show dependency tree / graph
 
Reported: 2016-02-04 17:45 PST by Matt Baker
Modified: 2016-03-02 22:26 PST (History)
8 users (show)

See Also:

Attachments
[Patch] Proposed Fix (1.46 KB, patch)
2016-02-04 17:57 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] Updated Memory timeline view (432.98 KB, image/png)
2016-02-04 17:59 PST, Matt Baker 		no flags Details
[Patch] Proposed Fix (1.83 KB, patch)
2016-03-02 21:30 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] Updated view with decreased padding (366.26 KB, image/png)
2016-03-02 21:32 PST, Matt Baker 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-02-04 17:45:04 PST 
* SUMMARY
Update MemoryTimelineView for the new ruler height. The change to ruler styles is part of https://bugs.webkit.org/show_bug.cgi?id=153034.
Comment 1 Radar WebKit Bug Importer 2016-02-04 17:45:59 PST 
<rdar://problem/24517259>
Comment 2 Matt Baker 2016-02-04 17:57:28 PST 
Created attachment 270710 [details]
[Patch] Proposed Fix
Comment 3 Matt Baker 2016-02-04 17:59:38 PST 
Created attachment 270711 [details]
[Image] Updated Memory timeline view
Comment 4 Joseph Pecoraro 2016-02-04 18:48:45 PST 
Comment on attachment 270710 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270710&action=review

> Source/WebInspectorUI/UserInterface/Views/MemoryTimelineView.css:59
> +    padding-top: 2px;

I still think a padding-left makes more sense. Previously this would have matched up with a title, but I got rid of that to reduce vertical space.
Comment 5 Timothy Hatcher 2016-03-02 20:02:54 PST 
What is the verdict here?
Comment 6 Matt Baker 2016-03-02 21:30:33 PST 
Created attachment 272729 [details]
[Patch] Proposed Fix
Comment 7 Matt Baker 2016-03-02 21:32:46 PST 
Created attachment 272730 [details]
[Image] Updated view with decreased padding

Not sure how "Categories" is supposed to be left-aligned, so I left it alone.
Comment 8 WebKit Commit Bot 2016-03-02 22:26:51 PST 
Comment on attachment 272729 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 272729

Committed r197493: <http://trac.webkit.org/changeset/197493>
Comment 9 WebKit Commit Bot 2016-03-02 22:26:55 PST 
All reviewed patches have been landed.  Closing bug.