Bug 153891 - Web Inspector: Replace all instances of '%s' with “%s”
Summary: Web Inspector: Replace all instances of '%s' with “%s”
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-04 13:09 PST by Devin Rousso
Modified: 2016-02-05 13:21 PST (History)
8 users (show)

See Also:

Attachments
Patch (11.56 KB, patch)
2016-02-05 12:27 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (11.56 KB, patch)
2016-02-05 12:52 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-02-04 13:09:05 PST 
These are primarily WebInspector.UIString() instances.
Comment 1 Radar WebKit Bug Importer 2016-02-04 13:09:45 PST 
<rdar://problem/24510236>
Comment 2 Devin Rousso 2016-02-05 12:27:31 PST 
Created attachment 270759 [details]
Patch
Comment 3 Timothy Hatcher 2016-02-05 12:41:31 PST 
Comment on attachment 270759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270759&action=review

> Source/WebInspectorUI/ChangeLog:9
> +        Switched all WebInspector.UIString() from using '' to ââ.

This should be “”. Not ““. (Look at it in a different font.)
Comment 4 Devin Rousso 2016-02-05 12:42:37 PST 
Comment on attachment 270759 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270759&action=review

>> Source/WebInspectorUI/ChangeLog:9
>> +        Switched all WebInspector.UIString() from using '' to ââ.
> 
> This should be “”. Not ““. (Look at it in a different font.)

It's the little things that count :) I'll change it now.
Comment 5 Devin Rousso 2016-02-05 12:52:56 PST 
Created attachment 270762 [details]
Patch
Comment 6 WebKit Commit Bot 2016-02-05 13:20:57 PST 
Comment on attachment 270762 [details]
Patch

Clearing flags on attachment: 270762

Committed r196184: <http://trac.webkit.org/changeset/196184>
Comment 7 WebKit Commit Bot 2016-02-05 13:21:01 PST 
All reviewed patches have been landed.  Closing bug.