Bug 153885 – [iOS Simulator] WebCoreNSURLSessionTest API tests BasicOperation and InvalidateEmpty failing

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Ryan Haddad]

[iOS Simulator] WebCoreNSURLSessionTest API tests BasicOperation and InvalidateEmpty failing

Started with <https://trac.webkit.org/changeset/196082>

<https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Release%20WK2%20%28Tests%29/builds/2843>

Tests that failed:
  WebCoreNSURLSessionTest.BasicOperation
  WebCoreNSURLSessionTest.InvalidateEmpty

[Jer Noble]

Interesting. I'll take a look.

[Jer Noble]

Created attachment 270706 [details]
Patch

[Alex Christensen]

I also have solutions to this in https://bugs.webkit.org/show_bug.cgi?id=153900

[Jer Noble]

For the meanwhile, before the more drastic change is made to +[WebView initialize], can we r+ this to get the iOS tests unblocked?

[Alex Christensen]

If we're just trying to fix tests, I think https://bugs.webkit.org/attachment.cgi?id=270700&action=review is a better solution than adding more UIKit SPI usage.

[Alexey Proskuryakov]

Comment on attachment 270706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270706&action=review

> Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:48
> +SOFT_LINK(UIKit, _UIApplicationLoadWebKit, void, (void), ())

If this is necessary for WebKit tests, should we do this in shared code?

The fix in https://bugs.webkit.org/show_bug.cgi?id=153900 seems preferable still, but I don't know if there is some reason why we can't do initialization in WebKit.

[Jer Noble]

*** This bug has been marked as a duplicate of bug 153900 ***