Bug 153880 – Web Inspector: Give nested inspectors their own process pool

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Give nested inspectors their own process pool.

When inspecting the inspector, in order for profiling information to be useful the inspector¹ and inspector² should be in separate processes (or at least not share the same VM). When sampling I was seeing JavaScript running in both inspectors in the sample, because they were sharing the same process and VM.

[Radar WebKit Bug Importer]

<rdar://problem/24508310>

[Joseph Pecoraro]

Created attachment 270676 [details]
[PATCH] Proposed Fix

We could create a Vector for pools per level, but I think just 2 pools is fine for now.

Needs a WK2 Owner nod.

[Timothy Hatcher]

Comment on attachment 270676 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=270676&action=review

> Source/WebKit2/UIProcess/WebInspectorProxy.cpp:314
> +    WebProcessPool* pool = inspectionLevel == 1 ? s_mainInspectorProcessPool : s_nestedInspectorProcessPool;

I think this needs to be a reference or a ** to make the later assignment work right. As it stands, I suspect this makes a new pool each time and s_mainInspectorProcessPool / s_nestedInspectorProcessPool are always null.

[Joseph Pecoraro]

Created attachment 270683 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 270683 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 270683

Committed r196142: <http://trac.webkit.org/changeset/196142>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.