Bug 15388 - RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)
Summary: RenderSVGContainer (<g>) should not repaint when its bounds change (unless it...
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 15389 15402
  Show dependency treegraph
Reported: 2007-10-05 21:58 PDT by Eric Seidel (no email)
Modified: 2007-10-06 02:01 PDT (History)
0 users

See Also:

test case (use quartz debug "flash on screen updates" to see the bug (609 bytes, application/xml)
2007-10-05 22:06 PDT, Eric Seidel (no email)
no flags Details
potential fix (18.04 KB, patch)
2007-10-06 00:37 PDT, Eric Seidel (no email)
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-05 21:58:53 PDT
RenderSVGContainer (<g>) should not repaint when its bounds change (unless it has a filter)

The only time a <g> actually causes pixels to be rendered to the screen is when it has a filter.  All other times, it shouldn't need to do any repainting.

Currently if you have an item moving inside a large <g>, causing the bounds of that <g> to change, the entire <g> will repaint!  I've attached a patch which addresses this, but seems to expose another repaint issue (or two), so it can't be landed at this time.
Comment 1 Eric Seidel (no email) 2007-10-05 22:06:16 PDT
Created attachment 16557 [details]
test case (use quartz debug "flash on screen updates" to see the bug
Comment 2 Eric Seidel (no email) 2007-10-06 00:37:52 PDT
Created attachment 16563 [details]
potential fix

This seems to dramatically improve lively kernel.  It does not however fix the attached test case.  The attached test case's behavior is changed, but the new behavior might actually be an intentional side effect of absoluteClippedOverflowRect() describing the size of the content of the <svg> instead of the actual svg's bounds.  I don't know enough about absoluteClippedOverflowRect's expected behavior to know for certain.

I'm also not sure this fix is 100% ready as I think it may regress Space Invaders ever so slightly:

I have not seen any other regressions in my surfing of the SVG web.
Comment 3 Eric Seidel (no email) 2007-10-06 00:51:16 PDT
bug 15352 covers other redraw issues for space invaders
Comment 4 Eric Seidel (no email) 2007-10-06 01:20:59 PDT
I was wrong.  Invaders is no worse than before.  This patch is ready for review.
Comment 5 Oliver Hunt 2007-10-06 01:34:08 PDT
Comment on attachment 16563 [details]
potential fix

r=me if you make a decent changelog, and confirm the correction on lively kerne;
Comment 6 Eric Seidel (no email) 2007-10-06 02:00:19 PDT
landed as r26077 on feature-branch.