Bug 153873 - [Mac] Adopt NSURLSession properties in AVAssetResourceLoader
Summary: [Mac] Adopt NSURLSession properties in AVAssetResourceLoader
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-04 10:24 PST by Jer Noble
Modified: 2016-02-09 12:56 PST (History)
2 users (show)

See Also:


Attachments
Patch (15.02 KB, patch)
2016-02-04 10:28 PST, Jer Noble
eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (15.09 KB, patch)
2016-02-04 10:50 PST, Jer Noble
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (637.78 KB, application/zip)
2016-02-04 11:15 PST, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (356.01 KB, application/zip)
2016-02-04 11:28 PST, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (324.46 KB, application/zip)
2016-02-04 11:28 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-02-04 10:24:21 PST
[Mac] Adopt NSURLSession properties in AVAssetResourceLoader
Comment 1 Jer Noble 2016-02-04 10:28:41 PST
Created attachment 270663 [details]
Patch
Comment 2 Eric Carlson 2016-02-04 10:43:50 PST
Comment on attachment 270663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270663&action=review

> Source/WebCore/page/Settings.cpp:599
> +    if (gAVFoundationEnabled == enabled)
> +        return;
> +
> +    gAVFoundationEnabled = enabled;

Nit: this check probably isn't worth the extra code it adds.
Comment 3 Jer Noble 2016-02-04 10:50:03 PST
Created attachment 270665 [details]
Patch for landing
Comment 4 Build Bot 2016-02-04 11:15:02 PST
Comment on attachment 270665 [details]
Patch for landing

Attachment 270665 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/782609

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-02-04 11:15:05 PST
Created attachment 270672 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-02-04 11:28:17 PST
Comment on attachment 270665 [details]
Patch for landing

Attachment 270665 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/782660

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-02-04 11:28:20 PST
Created attachment 270673 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-02-04 11:28:56 PST
Comment on attachment 270665 [details]
Patch for landing

Attachment 270665 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/782647

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-02-04 11:28:58 PST
Created attachment 270674 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 10 Jer Noble 2016-02-09 12:56:53 PST
Committed r196328: <http://trac.webkit.org/changeset/196328>