Implementation of Settings::setPrivateBrowsingEnabled was removed in r166661, but declaration is still here.
Created attachment 270659 [details] Patch
Comment on attachment 270659 [details] Patch Rejecting attachment 270659 [details] from review queue. annulen@yandex.ru does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
Comment on attachment 270659 [details] Patch Rejecting attachment 270659 [details] from commit-queue. annulen@yandex.ru does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 270659 [details] Patch Sorry, I've really meant to set flags to '?'.
Comment on attachment 270659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270659&action=review > Source/WebCore/ChangeLog:18 > + * page/Settings.h: > + (WebCore::Settings::dnsPrefetchingEnabled): Deleted. > + (WebCore::Settings::userStyleSheetLocation): Deleted. > + (WebCore::Settings::needsAcrobatFrameReloadingQuirk): Deleted. > + (WebCore::Settings::minimumDOMTimerInterval): Deleted. > + (WebCore::Settings::domTimerAlignmentInterval): Deleted. This is not accurate, please fix the ChangeLog.
Created attachment 270664 [details] Patch
Comment on attachment 270659 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270659&action=review >> Source/WebCore/ChangeLog:18 >> + (WebCore::Settings::domTimerAlignmentInterval): Deleted. > > This is not accurate, please fix the ChangeLog. Looks like prepare-ChangeLog should be the next target of my perl exercises :)
Comment on attachment 270664 [details] Patch Clearing flags on attachment: 270664 Committed r196134: <http://trac.webkit.org/changeset/196134>
All reviewed patches have been landed. Closing bug.