Bug 153853 - Logs/CoreSimulator filling up OS disk on WebKit testers
Summary: Logs/CoreSimulator filling up OS disk on WebKit testers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-03 19:27 PST by Aakash Jain
Modified: 2016-02-03 21:16 PST (History)
5 users (show)

See Also:

Attachments
Proposed patch (1.45 KB, patch)
2016-02-03 19:31 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-02-03 19:27:00 PST 
During the cleanup after running layout-test on ios, the ~/Library/Logs/CoreSimulator/`UDID` directory is not deleted. This can grow large over time, especially on bots which are regularly running layout-tests.
see <rdar://problem/24496003>
Comment 1 Aakash Jain 2016-02-03 19:31:34 PST 
Created attachment 270622 [details]
Proposed patch
Comment 2 Dean Johnson 2016-02-03 20:06:56 PST 
Comment on attachment 270622 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270622&action=review

> Tools/Scripts/webkitpy/port/ios.py:261
> +                    self.testing_device(i).udid), ignore_errors=True)

Code looks good to me, so r=me as long as you've tested that it works locally. :)
Comment 3 WebKit Commit Bot 2016-02-03 21:16:21 PST 
Comment on attachment 270622 [details]
Proposed patch

Clearing flags on attachment: 270622

Committed r196106: <http://trac.webkit.org/changeset/196106>
Comment 4 WebKit Commit Bot 2016-02-03 21:16:24 PST 
All reviewed patches have been landed.  Closing bug.