ArrayPrototype should have a destroy function

[Keith Miller]

ArrayPrototype should have a destroy function

[Keith Miller]

Created attachment 270612 [details]
Patch

[Andreas Kling]

Comment on attachment 270612 [details]
Patch

destroy() will not be called unless you also add
static const bool needsDestruction = true;
to ArrayPrototype.

(This will cause it to get allocated in a MarkedBlock that runs destructors.)

[Keith Miller]

rdar://problem/24494029

[Keith Miller]

Created attachment 270697 [details]
Patch

[Saam Barati]

Comment on attachment 270697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270697&action=review

> Source/JavaScriptCore/jsc.cpp:2092
> +        vm->heap.collectAllGarbage();

why not tear down the VM here?

[Keith Miller]

Per an offline conversation with Filip, users don't usually do it and a we want jsc.cpp to act in a way that models how people the framework. I wouldn't be opposed to adding another option doing so in a different patch, however.

[Filip Pizlo]

Comment on attachment 270697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270697&action=review

>> Source/JavaScriptCore/jsc.cpp:2092
>> +        vm->heap.collectAllGarbage();
> 
> why not tear down the VM here?

VM tear-down would test other things that maybe we don't want to test with gcAtEnd.

[WebKit Commit Bot]

Comment on attachment 270697 [details]
Patch

Clearing flags on attachment: 270697

Committed r196155: <http://trac.webkit.org/changeset/196155>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.