Bug 153842 - git-add-reviewer should work when run from a subdirectory within the repository
Summary: git-add-reviewer should work when run from a subdirectory within the repository
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brian Burg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-03 13:23 PST by Brian Burg
Modified: 2016-02-03 16:35 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.78 KB, patch)
2016-02-03 13:32 PST, Brian Burg
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Burg 2016-02-03 13:23:35 PST
There is a very old FIXME i'm about to delete.
Comment 1 Brian Burg 2016-02-03 13:32:03 PST
Created attachment 270598 [details]
Patch
Comment 2 David Kilzer (:ddkilzer) 2016-02-03 13:46:59 PST
Comment on attachment 270598 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270598&action=review

r=me

> Tools/ChangeLog:14
> +        fix this same issue for prepare-Changelogs.

Nit:  Capitalization of prepare-ChangeLogs.

> Tools/Scripts/git-add-reviewer:89
> +my $gitDirectory = gitDirectory();

I tend to dislike adding globals (when you could just call gitDirectory() at each place it's needed), but I don't feel strongly enough to r- this.
Comment 3 Brian Burg 2016-02-03 16:35:37 PST
Committed r196097: <http://trac.webkit.org/changeset/196097>