RESOLVED FIXED153842
git-add-reviewer should work when run from a subdirectory within the repository 
https://bugs.webkit.org/show_bug.cgi?id=153842
Summary git-add-reviewer should work when run from a subdirectory within the repository
Blaze Burg
Reported 2016-02-03 13:23:35 PST
There is a very old FIXME i'm about to delete.
Attachments
Patch (3.78 KB, patch)
2016-02-03 13:32 PST, Blaze Burg 		ddkilzer: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-02-03 13:32:03 PST
Created attachment 270598 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2016-02-03 13:46:59 PST
Comment on attachment 270598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270598&action=review r=me > Tools/ChangeLog:14 > + fix this same issue for prepare-Changelogs. Nit: Capitalization of prepare-ChangeLogs. > Tools/Scripts/git-add-reviewer:89 > +my $gitDirectory = gitDirectory(); I tend to dislike adding globals (when you could just call gitDirectory() at each place it's needed), but I don't feel strongly enough to r- this.
Blaze Burg
Comment 3 2016-02-03 16:35:37 PST
Committed r196097: <http://trac.webkit.org/changeset/196097>
Note You need to log in before you can comment on or make changes to this bug.