Bug 153833 - Timeouts in tests because of non implemented UIScriptController::singleTapAtPoint()
Summary: Timeouts in tests because of non implemented UIScriptController::singleTapAtP...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-03 09:35 PST by Adrien Plazas
Modified: 2016-02-08 05:43 PST (History)
4 users (show)

See Also:


Attachments
Skip tests using UIScriptController in WebKitGTK+. (1.56 KB, patch)
2016-02-04 02:24 PST, Adrien Plazas
simon.fraser: commit-queue-
Details | Formatted Diff | Diff
Skip tests using UIScriptController in WebKitGTK+. (1.42 KB, patch)
2016-02-08 00:40 PST, Adrien Plazas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien Plazas 2016-02-03 09:35:41 PST
Test fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html times out in GTK Linux 64-bit Debug (Tests) because UIScriptController::singleTapAtPoint() isn't implemented.

Lots of other methods of UIScriptController are not implemented and may be causing other tests to fail.
Comment 1 Simon Fraser (smfr) 2016-02-03 15:10:24 PST
Tests using UIScriptController stuff to generate events should all be skipped on non-iOS platforms.
Comment 2 Adrien Plazas 2016-02-04 02:24:29 PST
Created attachment 270647 [details]
Skip tests using UIScriptController in WebKitGTK+.
Comment 3 Simon Fraser (smfr) 2016-02-05 02:20:45 PST
Comment on attachment 270647 [details]
Skip tests using UIScriptController in WebKitGTK+.

View in context: https://bugs.webkit.org/attachment.cgi?id=270647&action=review

> LayoutTests/platform/gtk/TestExpectations:1505
> +webkit.org/b/153833 fast/harness/concurrent-ui-side-scripts.html [ Skip ]
> +webkit.org/b/153833 fast/harness/ui-side-scripts.html [ Skip ]

You should not skip these two. They test that UIScriptController is working.
Comment 4 Michael Catanzaro 2016-02-05 10:39:21 PST
The expectations should go under  2. EXPECTED FAILURES
Comment 5 Adrien Plazas 2016-02-08 00:40:16 PST
Created attachment 270847 [details]
Skip tests using UIScriptController in WebKitGTK+.
Comment 6 WebKit Commit Bot 2016-02-08 05:43:13 PST
Comment on attachment 270847 [details]
Skip tests using UIScriptController in WebKitGTK+.

Clearing flags on attachment: 270847

Committed r196250: <http://trac.webkit.org/changeset/196250>
Comment 7 WebKit Commit Bot 2016-02-08 05:43:17 PST
All reviewed patches have been landed.  Closing bug.