Bug 153827 - [Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
Summary: [Tools] Remove $additionalCMakeArgs variable because without this variable --...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joonghun Park
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-03 03:05 PST by Joonghun Park
Modified: 2016-02-03 15:07 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.71 KB, patch)
2016-02-03 04:25 PST, Joonghun Park 		no flags Details | Formatted Diff | Diff
Patch (2.14 KB, patch)
2016-02-03 05:01 PST, Joonghun Park 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joonghun Park 2016-02-03 03:05:43 PST 
When an array is passed to subroutines as argument in perl, a list containing its element is returned from the array.
Currently @$ arguments are being passed, then it is going to be one list including all the elements not only from @ but also from $.
As a result, $additionalCMakeArgs in sub generateBuildSystemFromCMakeProject is not being used.
Comment 1 Joonghun Park 2016-02-03 04:25:22 PST 
Created attachment 270569 [details]
Patch
Comment 2 Konstantin Tokarev 2016-02-03 04:39:13 PST 
I saw this bug but I decided that nobody needs $additionalCMakeArgs.
Comment 3 Joonghun Park 2016-02-03 04:41:20 PST 
(In reply to comment #2)
> I saw this bug but I decided that nobody needs $additionalCMakeArgs.

If the variable doesn't needed anymore, then maybe is it ok to be removed instead?
Comment 4 Konstantin Tokarev 2016-02-03 04:44:28 PST 
Looks like --cmakeargs works fine with this issue present, so it seems to be a good idea to remove dead code.
Comment 5 Joonghun Park 2016-02-03 04:50:36 PST 
(In reply to comment #4)
> Looks like --cmakeargs works fine with this issue present, so it seems to be
> a good idea to remove dead code.

All right, then I'm gonna remove this thing immediately.
Comment 6 Joonghun Park 2016-02-03 05:01:59 PST 
Created attachment 270571 [details]
Patch
Comment 7 Konstantin Tokarev 2016-02-03 05:37:49 PST 
LGTM.
Comment 8 WebKit Commit Bot 2016-02-03 15:06:56 PST 
Comment on attachment 270571 [details]
Patch

Clearing flags on attachment: 270571

Committed r196085: <http://trac.webkit.org/changeset/196085>
Comment 9 WebKit Commit Bot 2016-02-03 15:07:01 PST 
All reviewed patches have been landed.  Closing bug.