Bug 15382 - [CAIRO] Canvas pattern support
Summary: [CAIRO] Canvas pattern support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Cairo
: 16519 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-10-05 14:42 PDT by Alp Toker
Modified: 2007-12-24 22:20 PST (History)
0 users

See Also:

Attachments
Add canvas pattern support (10.68 KB, patch)
2007-12-23 13:11 PST, Alp Toker 		zecke: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alp Toker 2007-10-05 14:42:12 PDT 
The Cairo Canvas implementation currently lacks support for patterns. This should be added to CanvasPattern.cpp.
Comment 1 Alp Toker 2007-12-23 13:11:41 PST 
Created attachment 18073 [details]
Add canvas pattern support
Comment 2 Holger Freyther 2007-12-23 16:48:29 PST 
Comment on attachment 18073 [details]
Add canvas pattern support

-Try to remove the whitespace change to the RGBA32 lines before landing

-Check for !m_cachedImage->image in CanvasPatern::createPattern

-Free the surface in void CanvasRenderingContext2D::drawImage

-The Image/BitmapImage changes somehow remind me of nativeImageForCurrentFrame()
Comment 3 Alp Toker 2007-12-23 19:05:31 PST 
Landed in r28971, complete with the suggested nativeImageForCurrentFrame() change (decided not to copy the other ports but go with this cleaner abstraction).
Comment 4 Alp Toker 2007-12-24 22:20:45 PST 
*** Bug 16519 has been marked as a duplicate of this bug. ***