Bug 153815 - DFG, FTL, B3, and Air should all have a unique option for printing their graphs
Summary: DFG, FTL, B3, and Air should all have a unique option for printing their graphs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-02 20:01 PST by Keith Miller
Modified: 2016-05-29 10:55 PDT (History)
4 users (show)

See Also:


Attachments
Patch (10.37 KB, patch)
2016-02-02 20:15 PST, Keith Miller
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-02-02 20:01:54 PST
DFG, FTL, B3, and Air should all have a unique option for printing their graphs
Comment 1 Keith Miller 2016-02-02 20:15:14 PST
Created attachment 270542 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-02 20:53:44 PST
Comment on attachment 270542 [details]
Patch

Clearing flags on attachment: 270542

Committed r196044: <http://trac.webkit.org/changeset/196044>
Comment 3 WebKit Commit Bot 2016-02-02 20:53:46 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Filip Pizlo 2016-05-29 10:55:58 PDT
Comment on attachment 270542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270542&action=review

> Source/JavaScriptCore/b3/B3Common.h:36
> +enum B3ComplitationMode {

We should call this CompilationMode, not B3CompilationMode.  It's already in a namespace called B3, so this is tautological.