Bug 153814 - [JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
Summary: [JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-02 19:44 PST by Caitlin Potter (:caitp)
Modified: 2016-02-03 08:49 PST (History)
12 users (show)

See Also:

Attachments
Patch (2.77 KB, patch)
2016-02-02 19:45 PST, Caitlin Potter (:caitp) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caitlin Potter (:caitp) 2016-02-02 19:44:31 PST 
[JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
Comment 1 Caitlin Potter (:caitp) 2016-02-02 19:45:31 PST 
Created attachment 270541 [details]
Patch
Comment 2 Yusuke Suzuki 2016-02-02 19:58:24 PST 
Comment on attachment 270541 [details]
Patch

Nice, r=me
Comment 3 Caitlin Potter (:caitp) 2016-02-02 20:14:17 PST 
Comment on attachment 270541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review

> Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93
> +    // delete global[symbol];

I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess
Comment 4 Yusuke Suzuki 2016-02-02 20:18:38 PST 
Comment on attachment 270541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270541&action=review

>> Source/JavaScriptCore/tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:93
>> +    // delete global[symbol];
> 
> I think I have a fix for this crash (which is shipping in Safari atm :() --- I can include that in a separate bug though, I guess

OK, could you open a bug for that?
Comment 5 WebKit Commit Bot 2016-02-02 20:22:45 PST 
Comment on attachment 270541 [details]
Patch

Clearing flags on attachment: 270541

Committed r196042: <http://trac.webkit.org/changeset/196042>
Comment 6 WebKit Commit Bot 2016-02-02 20:22:51 PST 
All reviewed patches have been landed.  Closing bug.