Bug 153806 - Provide handleKeyWebEvent with completion handler
Summary: Provide handleKeyWebEvent with completion handler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-02 15:17 PST by Enrica Casucci
Modified: 2016-02-02 16:09 PST (History)
1 user (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2016-02-02 15:25 PST, Enrica Casucci 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-02-02 15:17:16 PST 
To support new keyboard architecture.
Comment 1 Enrica Casucci 2016-02-02 15:25:53 PST 
Created attachment 270527 [details]
Patch
Comment 2 Tim Horton 2016-02-02 15:29:36 PST 
Comment on attachment 270527 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270527&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2875
> +    _keyWebEventHandler = [completionHandler copy];

I think we have a smart pointer for blocks now!

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885
> +        return;

Confused. Why do you bail here? Don't we still have to do some of the work below?
Comment 3 Enrica Casucci 2016-02-02 15:32:10 PST 
(In reply to comment #2)
> Comment on attachment 270527 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=270527&action=review
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2875
> > +    _keyWebEventHandler = [completionHandler copy];
> 
> I think we have a smart pointer for blocks now!
> 
> > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2885
> > +        return;
> 
> Confused. Why do you bail here? Don't we still have to do some of the work
> below?

No we don't in this case.
I'll adopt the BlockPtr.
Comment 4 Enrica Casucci 2016-02-02 16:09:55 PST 
Committed revision 196037.