Bug 153788 - WEBGL_debug_shaders should be disabled for OpenGLES backend also
Summary: WEBGL_debug_shaders should be disabled for OpenGLES backend also
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinyoung Hur
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-02 07:32 PST by Jinyoung Hur
Modified: 2016-02-02 18:27 PST (History)
5 users (show)

See Also:

Attachments
Patch (2.96 KB, patch)
2016-02-02 07:52 PST, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (795.27 KB, application/zip)
2016-02-02 08:46 PST, Build Bot 		no flags Details
Patch (2.96 KB, patch)
2016-02-02 16:46 PST, Jinyoung Hur 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinyoung Hur 2016-02-02 07:32:31 PST 
On OpenGLES backed environment, webgl/1.0.2/conformance/extensions/webgl-debug-shaders.html fails with the same error related with https://bugs.webkit.org/show_bug.cgi?id=149734.
I think the codes that are disabling WEBGL_debug_shaders extension, which are implemented in Extensions3DOpenGL::supportsExtension(), should be moved to Extensions3DOpenGLCommon::supportsExtension() so that the webgl-debug-shaders extension is disabled for both OpenGL and OpenGLES backed systems.
Comment 1 Jinyoung Hur 2016-02-02 07:52:31 PST 
Created attachment 270487 [details]
Patch
Comment 2 Build Bot 2016-02-02 08:46:14 PST 
Comment on attachment 270487 [details]
Patch

Attachment 270487 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/772911

New failing tests:
imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-2.html
Comment 3 Build Bot 2016-02-02 08:46:16 PST 
Created attachment 270490 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Jinyoung Hur 2016-02-02 16:46:30 PST 
Created attachment 270529 [details]
Patch
Comment 5 WebKit Commit Bot 2016-02-02 18:27:32 PST 
Comment on attachment 270529 [details]
Patch

Clearing flags on attachment: 270529

Committed r196039: <http://trac.webkit.org/changeset/196039>
Comment 6 WebKit Commit Bot 2016-02-02 18:27:35 PST 
All reviewed patches have been landed.  Closing bug.