Bug 153765 - object.__lookupGetter__() / object.__lookupSetter__() does not work for native bindings
Summary: object.__lookupGetter__() / object.__lookupSetter__() does not work for nativ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on: 140575
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-01 14:05 PST by Chris Dumez
Modified: 2016-02-02 10:05 PST (History)
10 users (show)

See Also:


Attachments
Patch (10.81 KB, patch)
2016-02-01 21:28 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-02-01 14:05:51 PST
object.__lookupGetter__() / object.__lookupSetter__() does not work for native bindings.

E.g. Element.prototype.__lookupGetter__("tagName") or Element.prototype.__lookupGetter__("nodeName") return undefined instead of a function.
Comment 1 Chris Dumez 2016-02-01 14:06:14 PST
rdar://problem/24439699
Comment 2 Chris Dumez 2016-02-01 21:28:37 PST
Created attachment 270470 [details]
Patch
Comment 3 Chris Dumez 2016-02-01 22:35:14 PST
Comment on attachment 270470 [details]
Patch

Clearing flags on attachment: 270470

Committed r196004: <http://trac.webkit.org/changeset/196004>
Comment 4 Chris Dumez 2016-02-01 22:35:19 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Oliver Hunt 2016-02-02 10:05:41 PST
I find myself thinking that at this point we should probably just write these in JS