Bug 153764 - [iOS Simulator] fast/viewport/viewport-warnings-7.html failing
Summary: [iOS Simulator] fast/viewport/viewport-warnings-7.html failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad iOS 9.0
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 152130
  Show dependency treegraph
 
Reported: 2016-02-01 13:43 PST by Ryan Haddad
Modified: 2016-02-02 22:28 PST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-02-01 13:43:31 PST
[iOS Simulator] fast/viewport/viewport-warnings-7.html failing

<https://build.webkit.org/results/Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r195975%20(2771)/results.html>
<http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fviewport%2Fviewport-warnings-7.html>

--- /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/viewport-warnings-7-expected.txt
+++ /Volumes/Data/slave/ios-simulator-9-release-tests-wk2/build/layout-test-results/fast/viewport/viewport-warnings-7-actual.txt
@@ -1,3 +1,3 @@
-CONSOLE MESSAGE: line 5: Viewport argument value "123i̇" for key "width" was truncated to its numeric prefix.
+CONSOLE MESSAGE: line 5: Viewport argument value "123İ" for key "width" was truncated to its numeric prefix.
 ALERT: viewport size 123x135.3 scale 2.60163 with limits [2.60163, 5] and userScalable true
Comment 1 Ryan Haddad 2016-02-01 13:45:10 PST
Failing since <http://trac.webkit.org/changeset/195951>
Comment 2 Alexey Proskuryakov 2016-02-02 21:38:13 PST
This is a progression, please feel free to just update iOS results.

That said, it seems wrong that we log a transformed variant of the value instead of the original.
Comment 3 Darin Adler 2016-02-02 21:46:31 PST
I believe the old code was logging a transformed variant of the value. The new code logs the original. That’s what the progression is.
Comment 4 Darin Adler 2016-02-02 21:46:56 PST
Ryan, will you update the iOS expected result or would you like me to do it?
Comment 5 Darin Adler 2016-02-02 21:56:55 PST
Yes, confirmed. This new result logs the original value. So the progression is not because we longer lowercase non-ASCII characters; it’s because the new code doesn’t lowercase anything at all, and logs the original value.
Comment 6 Darin Adler 2016-02-02 22:28:03 PST
http://trac.webkit.org/changeset/196047