Bug 153757 - Add line grid pagination SPI to WebKit
Summary: Add line grid pagination SPI to WebKit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-02-01 13:10 PST by Dave Hyatt
Modified: 2016-02-02 12:54 PST (History)
6 users (show)

See Also:

Attachments
Patch (5.50 MB, patch)
2016-02-01 13:15 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (5.50 MB, patch)
2016-02-01 13:40 PST, Dave Hyatt 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-02-01 13:10:17 PST 
Add line grid pagination SPI to WebKit
Comment 1 Dave Hyatt 2016-02-01 13:15:44 PST 
Created attachment 270416 [details]
Patch
Comment 2 WebKit Commit Bot 2016-02-01 13:18:17 PST 
Attachment 270416 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderBox.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Dave Hyatt 2016-02-01 13:40:44 PST 
Created attachment 270419 [details]
Patch
Comment 4 Tim Horton 2016-02-02 11:19:45 PST 
Comment on attachment 270419 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270419&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:212
> +@property (nonatomic, setter=_setPaginationLineGridEnabled:) BOOL _paginationLineGridEnabled;

Does it make any sense to toggle this in a live view? I don't think so. So it should probably be on WKWebViewConfiguration.
Comment 5 Dave Hyatt 2016-02-02 11:50:13 PST 
Fixed in r196024.
Comment 6 Jon Lee 2016-02-02 12:54:11 PST 
rdar://problem/23041598