Bug 153719 - Debug build fails to link due to missing implementation of WebCore::Frame::isMainFrame()
Summary: Debug build fails to link due to missing implementation of WebCore::Frame::is...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2016-01-30 15:49 PST by Jeremy Huddleston Sequoia
Modified: 2016-01-30 17:16 PST (History)
4 users (show)

See Also:

patch (1.44 KB, patch)
2016-01-30 16:03 PST, Jeremy Huddleston Sequoia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Huddleston Sequoia 2016-01-30 15:49:50 PST
When building the debug configuration, libwebkit2gtk fails to link with:

:info:build Undefined symbols for architecture x86_64:
:info:build   "WebCore::Frame::isMainFrame() const", referenced from:
:info:build       WebCore::printRenderTreeForLiveDocuments() in libWebCoreGTK.a(RenderObject.cpp.o)
:info:build ld: symbol(s) not found for architecture x86_64
:info:build clang: error: linker command failed with exit code 1 (use -v to see invocation)
:info:build make[2]: *** [lib/libwebkit2gtk-] Error 1

The function is only present in debug builds, so it's certainly no surprise that the release build compiles fine:

#ifndef NDEBUG
void printRenderTreeForLiveDocuments()
    for (const auto* document : Document::allDocuments()) {
        if (!document->renderView() || document->inPageCache())
        if (document->frame() && document->frame()->isMainFrame())
            fprintf(stderr, "----------------------main frame--------------------------\n");
        fprintf(stderr, "%s", document->url().string().utf8().data());
} // namespace WebCore

This was observed on OSX with webkitgtk-2.11.4 configured as:
Comment 1 Jeremy Huddleston Sequoia 2016-01-30 15:59:39 PST
I suspect this is just a missing include of MainFrame.h.  Testing that out now.
Comment 2 Jeremy Huddleston Sequoia 2016-01-30 16:03:57 PST
Created attachment 270324 [details]
Comment 3 WebKit Commit Bot 2016-01-30 17:15:58 PST
Comment on attachment 270324 [details]

Clearing flags on attachment: 270324

Committed r195918: <http://trac.webkit.org/changeset/195918>
Comment 4 WebKit Commit Bot 2016-01-30 17:16:01 PST
All reviewed patches have been landed.  Closing bug.