Bug 153718 - [Cocoa] Get rid of many WK_ macros for nullability
Summary: [Cocoa] Get rid of many WK_ macros for nullability
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-30 14:51 PST by mitz
Modified: 2016-01-30 20:19 PST (History)
4 users (show)

See Also:


Attachments
Use nullability attributes and specifiers directly in the headers (34.06 KB, patch)
2016-01-30 14:56 PST, mitz
no flags Details | Formatted Diff | Diff
Use nullability attributes and specifiers directly in the headers where possible (32.67 KB, patch)
2016-01-30 17:45 PST, mitz
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2016-01-30 14:51:32 PST
I think we no longer need to build with compilers and SDKs that don’t support nullability, so we can use nullability specifiers and attributes directly in the headers. Patch forthcoming.
Comment 1 mitz 2016-01-30 14:56:37 PST
Created attachment 270323 [details]
Use nullability attributes and specifiers directly in the headers
Comment 2 mitz 2016-01-30 15:50:49 PST
Committed <http://trac.webkit.org/r195914>.
Comment 4 mitz 2016-01-30 17:14:36 PST
(In reply to comment #3)
> This broke the build:
> https://build.webkit.org/builders/Apple%20Yosemite%20Release%20%28Build%29/
> builds/12095/steps/compile-webkit/logs/errors

It needs to be reverted. I can do so in a few minutes if no one beats me to it.
Comment 5 mitz 2016-01-30 17:23:12 PST
Reverted in <http://trac.webkit.org/r195920>.
Comment 6 mitz 2016-01-30 17:45:52 PST
Created attachment 270330 [details]
Use nullability attributes and specifiers directly in the headers where possible
Comment 7 Simon Fraser (smfr) 2016-01-30 19:05:23 PST
Comment on attachment 270330 [details]
Use nullability attributes and specifiers directly in the headers where possible

rs=me
Comment 8 mitz 2016-01-30 20:12:07 PST
Committed attachment 270330 [details] as <http://trac.webkit.org/r195922>.