RESOLVED FIXED Bug 153718
[Cocoa] Get rid of many WK_ macros for nullability 
https://bugs.webkit.org/show_bug.cgi?id=153718
Summary [Cocoa] Get rid of many WK_ macros for nullability
mitz
Reported 2016-01-30 14:51:32 PST
I think we no longer need to build with compilers and SDKs that don’t support nullability, so we can use nullability specifiers and attributes directly in the headers. Patch forthcoming.
Attachments
Use nullability attributes and specifiers directly in the headers (34.06 KB, patch)
2016-01-30 14:56 PST, mitz 		no flags
DetailsFormatted DiffDiff
Use nullability attributes and specifiers directly in the headers where possible (32.67 KB, patch)
2016-01-30 17:45 PST, mitz 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2016-01-30 14:56:37 PST
Created attachment 270323 [details] Use nullability attributes and specifiers directly in the headers
mitz
Comment 2 2016-01-30 15:50:49 PST
Committed <http://trac.webkit.org/r195914>.
mitz
Comment 4 2016-01-30 17:14:36 PST
(In reply to comment #3) > This broke the build: > https://build.webkit.org/builders/Apple%20Yosemite%20Release%20%28Build%29/ > builds/12095/steps/compile-webkit/logs/errors It needs to be reverted. I can do so in a few minutes if no one beats me to it.
mitz
Comment 5 2016-01-30 17:23:12 PST
Reverted in <http://trac.webkit.org/r195920>.
mitz
Comment 6 2016-01-30 17:45:52 PST
Created attachment 270330 [details] Use nullability attributes and specifiers directly in the headers where possible
Simon Fraser (smfr)
Comment 7 2016-01-30 19:05:23 PST
Comment on attachment 270330 [details] Use nullability attributes and specifiers directly in the headers where possible rs=me
mitz
Comment 8 2016-01-30 20:12:07 PST
Committed attachment 270330 [details] as <http://trac.webkit.org/r195922>.
Note You need to log in before you can comment on or make changes to this bug.