Some factory functions have used std::unique_ptr<> instead of std::make_unique<>. In those cases we need to use std::make_unique<> directly.
Created attachment 270305 [details] Patch
Comment on attachment 270305 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270305&action=review > Source/WebCore/platform/cf/RunLoopObserver.h:41 > + // WEBCORE_EXPORT static std::unique_ptr<RunLoopObserver> create(CFIndex order, RunLoopObserverCallback callback); We should not keep this commented out code.
Created attachment 270336 [details] Patch for landing
(In reply to comment #2) > Comment on attachment 270305 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=270305&action=review > > > Source/WebCore/platform/cf/RunLoopObserver.h:41 > > + // WEBCORE_EXPORT static std::unique_ptr<RunLoopObserver> create(CFIndex order, RunLoopObserverCallback callback); > > We should not keep this commented out code. Oops. Removed.
Comment on attachment 270336 [details] Patch for landing Clearing flags on attachment: 270336 Committed r195925: <http://trac.webkit.org/changeset/195925>
All reviewed patches have been landed. Closing bug.