Bug 153694 - [JSC] IRC can coalesce the frame pointer with a Tmp that is modified
Summary: [JSC] IRC can coalesce the frame pointer with a Tmp that is modified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-29 20:10 PST by Benjamin Poulain
Modified: 2016-02-01 15:19 PST (History)
6 users (show)

See Also:


Attachments
Patch (7.53 KB, patch)
2016-01-29 20:44 PST, Benjamin Poulain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-01-29 20:10:04 PST
[JSC] IRC can coalesce the frame pointer with a Tmp that is modified
Comment 1 Benjamin Poulain 2016-01-29 20:44:45 PST
Created attachment 270288 [details]
Patch
Comment 2 Filip Pizlo 2016-02-01 14:29:36 PST
Comment on attachment 270288 [details]
Patch

Can you also fix the instruction selector to always have FramePointer use GPRInfo::callFrameRegister instead of creating a new tmp and pointless moves?
Comment 3 WebKit Commit Bot 2016-02-01 15:19:32 PST
Comment on attachment 270288 [details]
Patch

Clearing flags on attachment: 270288

Committed r195981: <http://trac.webkit.org/changeset/195981>
Comment 4 WebKit Commit Bot 2016-02-01 15:19:35 PST
All reviewed patches have been landed.  Closing bug.