Bug 153671 - Web Inspector: WebInspector.Setting should not access localStorage if the value did not change
Summary: Web Inspector: WebInspector.Setting should not access localStorage if the val...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-29 13:55 PST by Joseph Pecoraro
Modified: 2016-01-29 14:59 PST (History)
8 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.33 KB, patch)
2016-01-29 13:56 PST, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-01-29 13:55:23 PST
* SUMMARY
WebInspector.Setting should not access localStorage if the value did not change

* NOTES
Was seeing this in some profiles. We set the value of a setting, which did not change the setting, quite often. We can bail for most, trivial, cases.
Comment 1 Radar WebKit Bug Importer 2016-01-29 13:55:50 PST
<rdar://problem/24417029>
Comment 2 Joseph Pecoraro 2016-01-29 13:56:38 PST
Created attachment 270252 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2016-01-29 14:10:38 PST
Comment on attachment 270252 [details]
[PATCH] Proposed Fix

r=me, whoops
Comment 4 WebKit Commit Bot 2016-01-29 14:59:27 PST
Comment on attachment 270252 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 270252

Committed r195842: <http://trac.webkit.org/changeset/195842>
Comment 5 WebKit Commit Bot 2016-01-29 14:59:32 PST
All reviewed patches have been landed.  Closing bug.