RESOLVED FIXED 153671
Web Inspector: WebInspector.Setting should not access localStorage if the value did not change 
https://bugs.webkit.org/show_bug.cgi?id=153671
Summary Web Inspector: WebInspector.Setting should not access localStorage if the val...
Joseph Pecoraro
Reported 2016-01-29 13:55:23 PST
* SUMMARY WebInspector.Setting should not access localStorage if the value did not change * NOTES Was seeing this in some profiles. We set the value of a setting, which did not change the setting, quite often. We can bail for most, trivial, cases.
Attachments
[PATCH] Proposed Fix (1.33 KB, patch)
2016-01-29 13:56 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-01-29 13:55:50 PST
<rdar://problem/24417029>
Joseph Pecoraro
Comment 2 2016-01-29 13:56:38 PST
Created attachment 270252 [details] [PATCH] Proposed Fix
Blaze Burg
Comment 3 2016-01-29 14:10:38 PST
Comment on attachment 270252 [details] [PATCH] Proposed Fix r=me, whoops
WebKit Commit Bot
Comment 4 2016-01-29 14:59:27 PST
Comment on attachment 270252 [details] [PATCH] Proposed Fix Clearing flags on attachment: 270252 Committed r195842: <http://trac.webkit.org/changeset/195842>
WebKit Commit Bot
Comment 5 2016-01-29 14:59:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.