Bug 153664 - More than one audio and/or text track sometimes selected in media controls menu
Summary: More than one audio and/or text track sometimes selected in media controls menu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-29 12:40 PST by Eric Carlson
Modified: 2016-01-30 14:23 PST (History)
3 users (show)

See Also:


Attachments
The problem (196.32 KB, image/png)
2016-01-29 12:41 PST, Eric Carlson
no flags Details
Proposed patch (16.53 KB, patch)
2016-01-29 15:22 PST, Eric Carlson
jer.noble: review+
Details | Formatted Diff | Diff
Updated patch for the bots. (16.54 KB, patch)
2016-01-29 15:50 PST, Eric Carlson
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (777.62 KB, application/zip)
2016-01-29 18:16 PST, Build Bot
no flags Details
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (826.85 KB, application/zip)
2016-01-29 18:19 PST, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (899.64 KB, application/zip)
2016-01-29 18:44 PST, Build Bot
no flags Details
Patch with even less unwanted debugging code. (17.09 KB, patch)
2016-01-30 07:50 PST, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2016-01-29 12:40:32 PST
Sometimes more than one audio and/or text track is selected in the track menu. It seems to be related to the use of the ::before pseudo-element in the shadow DOM.
Comment 1 Eric Carlson 2016-01-29 12:41:09 PST
Created attachment 270243 [details]
The problem
Comment 2 Eric Carlson 2016-01-29 15:22:01 PST
Created attachment 270263 [details]
Proposed patch
Comment 3 Jer Noble 2016-01-29 15:28:18 PST
Comment on attachment 270263 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270263&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1839
>            if (offMenu && displayMode === 'forced-only' && !trackMenuItemSelected) {
>                offMenu.classList.add(this.ClassNames.selected);
>                menuItem.setAttribute('tabindex', '0');
>                menuItem.setAttribute('aria-checked', 'true');
>            }

You should fix this while you're in here.
Comment 4 Eric Carlson 2016-01-29 15:50:11 PST
Created attachment 270267 [details]
Updated patch for the bots.
Comment 5 Build Bot 2016-01-29 18:16:55 PST
Comment on attachment 270267 [details]
Updated patch for the bots.

Attachment 270267 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/757401

Number of test failures exceeded the failure limit.
Comment 6 Build Bot 2016-01-29 18:16:58 PST
Created attachment 270281 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-01-29 18:19:45 PST
Comment on attachment 270267 [details]
Updated patch for the bots.

Attachment 270267 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/757411

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2016-01-29 18:19:47 PST
Created attachment 270282 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-01-29 18:44:04 PST
Comment on attachment 270267 [details]
Updated patch for the bots.

Attachment 270267 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/757461

Number of test failures exceeded the failure limit.
Comment 10 Build Bot 2016-01-29 18:44:07 PST
Created attachment 270283 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 11 Eric Carlson 2016-01-30 07:50:03 PST
Created attachment 270307 [details]
Patch with even less unwanted debugging code.
Comment 12 Eric Carlson 2016-01-30 14:22:54 PST
Committed r195912: https://trac.webkit.org/r195912