Bug 153664 – More than one audio and/or text track sometimes selected in media controls menu

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Sometimes more than one audio and/or text track is selected in the track menu. It seems to be related to the use of the ::before pseudo-element in the shadow DOM.

[Eric Carlson]

Created attachment 270243 [details]
The problem

[Eric Carlson]

Created attachment 270263 [details]
Proposed patch

[Jer Noble]

Comment on attachment 270263 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270263&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1839
>            if (offMenu && displayMode === 'forced-only' && !trackMenuItemSelected) {
>                offMenu.classList.add(this.ClassNames.selected);
>                menuItem.setAttribute('tabindex', '0');
>                menuItem.setAttribute('aria-checked', 'true');
>            }

You should fix this while you're in here.

[Eric Carlson]

Created attachment 270267 [details]
Updated patch for the bots.

[Build Bot]

Comment on attachment 270267 [details]
Updated patch for the bots.

Attachment 270267 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/757401

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 270281 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 270267 [details]
Updated patch for the bots.

Attachment 270267 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/757411

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 270282 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 270267 [details]
Updated patch for the bots.

Attachment 270267 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/757461

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 270283 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 270307 [details]
Patch with even less unwanted debugging code.

[Eric Carlson]

Committed r195912: https://trac.webkit.org/r195912