Bug 153655 - Disable text interaction with pencil
Summary: Disable text interaction with pencil
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-29 10:29 PST by Enrica Casucci
Modified: 2016-02-01 13:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2016-01-29 10:33 PST, Enrica Casucci 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2016-01-29 10:29:11 PST 
We don't want the pencil to be used for selecting text or zoom.

rdar://problem/24337778
Comment 1 Enrica Casucci 2016-01-29 10:33:28 PST 
Created attachment 270222 [details]
Patch
Comment 2 Tim Horton 2016-01-29 10:38:38 PST 
Comment on attachment 270222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=270222&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:437
> +    _doubleTapGestureRecognizer.get().allowedTouchTypes = @[@(UITouchTypeDirect)];

[_doubleTapGestureRecognizer allowedTouchTypes] (we do prefer dot notation but not in the case where you have to do this horrible .get(). thing, I think.
spaces inside the @[]

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1336
> +    UITouch *touch = (UITouch *)[gestureRecognizer.touches lastObject];

Do you really need this cast? Should be id -> UITouch * which should work without complaint.
Comment 3 Enrica Casucci 2016-01-29 11:09:16 PST 
Committed revision 195826.