Bug 153647 – [B3] JetStream/quicksort.c fails/hangs on Linux with GCC

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Csaba Osztrogonác]

With enabled B3-FTL, JetStream hangs during running quicksort.c benchmark.
Once I got "error" message instead of number, but almost always it stucks
in an infinite loop with 100% CPU load. No problem with LLVM-FTL.

[Csaba Osztrogonác]

It seems it is one more GCC/Clang related issue. 
quicksort.c test fails with GCC, but no problem with Clang.

[Michael Catanzaro]

Oh "good," so it will seem fine for developers but be broken for all our users.

[Yusuke Suzuki]

With GCC 4.9 debug build, it does not occur.
I guess there are some issue about C++ ill-formed code.

[Yusuke Suzuki]

Ah, ok, I've found the issue. I'll create the patch for that.

[Yusuke Suzuki]

I'm now creating the patch. But seeing the result, this issue may fix script-tests/array-enumerators-functions.js at the same time.
If it is fixed, Linux x64 GTK B3 works completely :D

[Yusuke Suzuki]

Created attachment 270314 [details]
Patch

[WebKit Commit Bot]

Attachment 270314 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:107:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:109:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:111:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:117:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:117:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:123:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:123:  One space before end of line comments  [whitespace/comments] [5]
ERROR: Source/JavaScriptCore/b3/B3ComputeDivisionMagic.h:128:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 8 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yusuke Suzuki]

Committed r195906: <http://trac.webkit.org/changeset/195906>

[Carlos Garcia Campos]

*** Bug 153644 has been marked as a duplicate of this bug. ***